[
https://issues.apache.org/jira/browse/FLINK-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552960#comment-16552960
]
ASF GitHub Bot commented on FLINK-9911:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204434452
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -323,7 +323,7 @@ public void disconnectResourceManager() {
boolean allowQueuedScheduling,
Time allocationTimeout) {
- log.debug("Allocating slot with request {} for task execution
{}", slotRequestId, task.getTaskToExecute());
+ log.debug("Received slot request [{}] for task: {}",
slotRequestId, task.getTaskToExecute());
--- End diff --
I tried to change it for all ids (`SlotRequestID` and `AllocationID`)
because they now print `SlotRequestID{1234...}` and `AllocationID{9876...}` in
order to make them easier to identify.
> SlotPool#failAllocation is called outside of main thread
> --------------------------------------------------------
>
> Key: FLINK-9911
> URL: https://issues.apache.org/jira/browse/FLINK-9911
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.5.1, 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.5.2, 1.6.0
>
>
> The {{JobMaster}} calls directly into the {{SlotPool#failAllocation}} in the
> method {{JobMaster#notifyAllocationFailure}}. This can the {{SlotPool}} to go
> into an inconsistent state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
