Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204758828
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
 ---
    @@ -176,7 +175,7 @@ public void setDelayMillis(long delayMillis) {
        private AtomicLong numPendingRequests = new AtomicLong(0);
     
        /** Elasticsearch client created using the call bridge. */
    -   private transient Client client;
    +   private transient AutoCloseable client;
    --- End diff --
    
    Same here. Why not parameterize the class and be type save?


---

Reply via email to