[ 
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555241#comment-16555241
 ] 

ASF GitHub Bot commented on FLINK-9885:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204752713
  
    --- Diff: docs/dev/connectors/elasticsearch.md ---
    @@ -190,9 +220,30 @@ input.addSink(new ElasticsearchSink(config, 
transportAddresses, new Elasticsearc
     }))
     {% endhighlight %}
     </div>
    +<div data-lang="scala, Elasticsearch 6.x" markdown="1">
    +{% highlight scala %}
    +val input: DataStream[String] = ...
    +
    +val httpHosts = new java.util.ArrayList[HttpHost]
    +httpHosts.add(new HttpHost("127.0.0.1", 9300, "http"))
    +httpHosts.add(new HttpHost("10.2.3.1", 9300, "http"))
    +
    +input.addSink(new ElasticsearchSink(httpHosts, new 
ElasticsearchSinkFunction[String] {
    +  def createIndexRequest(element: String): IndexRequest = {
    +    val json = new java.util.HashMap[String, String]
    +    json.put("data", element)
    +    
    +    return Requests.indexRequest()
    +            .index("my-index")
    +            .type("my-type")
    +            .source(json)
    +  }
    +}))
    +{% endhighlight %}
    +</div>
     </div>
     
    -Note how a `Map` of `String`s is used to configure the `ElasticsearchSink`.
    +Note how `TransportClient` based version use a `Map` of `String`s is used 
to configure the `ElasticsearchSink`.
    --- End diff --
    
    Remove "is used to"?


> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
>                 Key: FLINK-9885
>                 URL: https://issues.apache.org/jira/browse/FLINK-9885
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This 
> should also come with an end-to-end test that covers this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to