GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/6418

    [FLINK-9939][runtime] Mesos: Not setting TMP dirs causes NPE

    ## What is the purpose of the change
    
    *This fixes a possible NPE when deploying on Mesos.*
    
    ## Brief change log
    
      - *Add null check to 
`BootstrapTools.updateTmpDirectoriesInConfiguration(...)`, and add `@Nullable` 
annotation.*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
      - *Added unit test to assert that `updateTmpDirectoriesInConfiguration` 
can handle `null` values.*
      - *Manually deployed on Mesos.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-9939

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6418
    
----
commit eb03ada77db7633d330be7847dbdf9ee801a9bee
Author: gyao <gary@...>
Date:   2018-07-25T10:23:20Z

    [hotfix][tests] Fix checkstyle violations in BootstrapToolsTest.

commit 261d4d7423b9ca179ac0004625f51b7b71655d63
Author: gyao <gary@...>
Date:   2018-07-25T11:57:34Z

    [FLINK-9939][runtime] Add null check before setting tmp dirs in config.

----


---

Reply via email to