[
https://issues.apache.org/jira/browse/FLINK-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555994#comment-16555994
]
ASF GitHub Bot commented on FLINK-9944:
---------------------------------------
zentol commented on a change in pull request #6421: [FLINK-9944][tests] Cleanup
end-to-end test poms
URL: https://github.com/apache/flink/pull/6421#discussion_r205191554
##########
File path: flink-end-to-end-tests/flink-queryable-state-test/pom.xml
##########
@@ -33,98 +33,54 @@
<packaging>jar</packaging>
<dependencies>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-core</artifactId>
- <version>${project.version}</version>
- </dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-statebackend-rocksdb_${scala.binary.version}</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-jar-plugin</artifactId>
- <version>2.4</version>
-
+ <artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<id>QsStateProducer</id>
<phase>package</phase>
<goals>
- <goal>jar</goal>
+ <goal>shade</goal>
</goals>
<configuration>
-
<classifier>QsStateProducer</classifier>
- <archive>
-
<manifestEntries>
-
<program-class>
-
org.apache.flink.streaming.tests.queryablestate.QsStateProducer
-
</program-class>
-
</manifestEntries>
- </archive>
+
<finalName>QsStateProducer</finalName>
+ <transformers>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+
<mainClass>org.apache.flink.streaming.tests.queryablestate.QsStateProducer</mainClass>
+ </transformer>
+ </transformers>
</configuration>
</execution>
- </executions>
- </plugin>
-
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <executions>
-
<execution>
<id>QsStateClient</id>
Review comment:
this jar must be a fat jar containing flink-core and possibly other
dependencies as it is not run as a flink application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cleanup end-to-end test poms
> ----------------------------
>
> Key: FLINK-9944
> URL: https://issues.apache.org/jira/browse/FLINK-9944
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Tests
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The poms for the various end-to-end modules require some attention.
> We can streamline the shade-plugin configuration by moving common elements to
> the parent pom.
> Most modules explicitly depend on flink-core; in the spirit of being similar
> to quickstart projects (i.e. the template for user-jars) we should remove
> this dependency. It is transitively pulled in by the API modules flink-java
> and flink-streaming-java.
> Other problems:
> * several flink dependencies are not set to provided
> * the datastream-allround-test has a hard-coded scala version in it's rocksdb
> dependency.
> * The ttl test depends on rocksdb but doesn't actually use it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
