yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205753578
##########
File path:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/messages/KvStateRequest.java
##########
@@ -70,17 +73,23 @@ public int getKeyHashCode() {
return serializedKeyAndNamespace;
}
+ public byte[] getSerializedStateDescriptor() {
+ return serializedStateDescriptor;
+ }
+
@Override
public byte[] serialize() {
byte[] serializedStateName =
stateName.getBytes(ConfigConstants.DEFAULT_CHARSET);
// JobID + stateName + sizeOf(stateName) + hashCode +
keyAndNamespace + sizeOf(keyAndNamespace)
+ // + stateDescriptor + sizeOf(stateDescriptor)
final int size =
JobID.SIZE +
serializedStateName.length + Integer.BYTES +
Integer.BYTES +
- serializedKeyAndNamespace.length +
Integer.BYTES;
+ serializedKeyAndNamespace.length + Integer.BYTES
+ + serializedStateDescriptor.length +
Integer.BYTES;
Review comment:
put the "+" behind the previous line looks better to me~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
