[
https://issues.apache.org/jira/browse/FLINK-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563377#comment-16563377
]
Timo Walther commented on FLINK-9977:
-------------------------------------
Thanks for working on this [~xccui]. I had a quick look at the branch. The docs
look very good! I will try to address your issues:
1. I also thought that we don't support the ESCAPE in LIKE. I don't know why it
is documented. Feel free to open Jira issues if there is not one already.
2. Yes you are right. It should support this case.
3. The general SQL-way of handling nulls should be if one argument is NULL the
result should be NULL. We should definitely unify LOG10 there.
4. This is a Calcite thing. E.g. MySQL does not allow PI but only PI()
5. +1 for this suggestion.
6. Yes, we could move it to the value constructor section. Or a new one. I
think it was added there because in Table API it is more like a function.
7. Please open an issue for this.
8. It does not harm to complete it. This test should just test the proper
conversion that Calcite performs for some functions. So even though we didn't
add runtime functions explicitly sometimes we support it. This is what this
test covers.
9. Don't remove it. This is a valid statement. See
https://dba.stackexchange.com/questions/127564/how-to-use-count-with-multiple-columns
10. No, there is a discussion in FLINK-5315.
11. We can also use a different style.
> Refine the docs for Table/SQL built-in functions
> ------------------------------------------------
>
> Key: FLINK-9977
> URL: https://issues.apache.org/jira/browse/FLINK-9977
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
> Priority: Minor
>
> There exist some syntax errors or inconsistencies in documents and Scala docs
> of the Table/SQL built-in functions. This issue aims to make some
> improvements to them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
