twalthr commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101]
Finalize Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206505701
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/Elasticsearch6ApiCallBridge.java
##########
@@ -65,12 +66,16 @@
}
@Override
- public RestHighLevelClient createClient(Map<String, String>
clientConfig) {
+ public RestHighLevelClient createClient(Map<String, String>
clientConfig) throws IOException {
RestClientBuilder builder =
RestClient.builder(httpHosts.toArray(new HttpHost[httpHosts.size()]));
restClientFactory.configureRestClientBuilder(builder);
RestHighLevelClient rhlClient = new
RestHighLevelClient(builder);
+ if (!rhlClient.ping()) {
Review comment:
Should we add some logging here for information that we perform a
communication step?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
