[ 
https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653681#comment-14653681
 ] 

ASF GitHub Bot commented on FLINK-2457:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/983#discussion_r36190666
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
    @@ -391,6 +392,10 @@ protected TypeExtractor() {
                                curT = typeToClass(curT).getGenericSuperclass();
                        }
                        
    +                   if(typeToClass(curT).equals(Tuple0.class)) {
    --- End diff --
    
    Yes it can. But in this case we are not done and do not return here. The 
test for `if (curT instanceof Class<?>)` is done below... This `if` is an early 
return that is only valid if the type is `Tuple0`. Or do I miss something?


> Integrate Tuple0
> ----------------
>
>                 Key: FLINK-2457
>                 URL: https://issues.apache.org/jira/browse/FLINK-2457
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Tuple0 is not cleanly integrated:
>   - missing serialization/deserialization support in runtime
>  - Tuple.getTupleClass(int arity) cannot handle arity zero, ie, cannot create 
> an instance of Tuple0
> Tuple0 is currently only used in Python API, but will be integrated into 
> Storm compatibility, too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to