[
https://issues.apache.org/jira/browse/FLINK-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564122#comment-16564122
]
ASF GitHub Bot commented on FLINK-9986:
---------------------------------------
zentol closed pull request #6443: [FLINK-9986][build] Only include commit info
in .version.properties file
URL: https://github.com/apache/flink/pull/6443
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml
index ab4521cf51f..271582fb5e8 100644
--- a/flink-runtime/pom.xml
+++ b/flink-runtime/pom.xml
@@ -470,7 +470,7 @@ under the License.
Used to show the git ref when starting
the jobManager. -->
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
- <version>2.1.5</version>
+ <version>2.1.14</version>
<executions>
<execution>
<goals>
@@ -484,6 +484,9 @@ under the License.
<skipPoms>false</skipPoms>
<failOnNoGitDirectory>false</failOnNoGitDirectory>
<generateGitPropertiesFilename>src/main/resources/.version.properties</generateGitPropertiesFilename>
+ <includeOnlyProperties>
+
<includeOnlyProperty>git.commit.*</includeOnlyProperty>
+ </includeOnlyProperties>
<gitDescribe>
<!-- don't generate the
describe property -->
<skip>true</skip>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unnecessary information from .version.properties file
> ------------------------------------------------------------
>
> Key: FLINK-9986
> URL: https://issues.apache.org/jira/browse/FLINK-9986
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.4.2, 1.5.1, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> To log the revision {{flink-runtime}} creates a {{.version.properties}} file
> using the {{git-commit-id-plugin}} that is stored within the jar.
> Here's an example:
> {code}
> git.commit.id.abbrev=1a9b648
> [email protected]
> git.commit.message.full=Commit for release 1.5.2\n
> git.commit.id=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.message.short=Commit for release 1.5.2
> git.commit.user.name=zentol
> git.build.user.name=zentol
> [email protected]
> git.branch=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.time=25.07.2018 @ 17\:10\:13 GMT
> git.build.time=25.07.2018 @ 20\:47\:15 GMT
> git.remote.origin.url=https\://github.com/zentol/flink.git
> {code}
> most of this information isn't used, as flink-runtime only access
> {{git.commit.id.abbrev}} and {{git.commit.time}}.
> The build, remote and branch information should be removed as they are
> neither relevant, nor consistent, as releases can be created on any branch,
> under any git alias, against any remote.
> To exclude properties we have to bump the plugin version to 2.1.9.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
