tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos]
WIP
URL: https://github.com/apache/flink/pull/6464#discussion_r207294014
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -345,15 +382,20 @@ private void recoverWorkers() throws Exception {
CompletableFuture<Boolean> stopReconciliationCoordinatorFuture
= stopActor(reconciliationCoordinator, stopTimeout);
reconciliationCoordinator = null;
- CompletableFuture<Void> stopFuture = CompletableFuture.allOf(
+ return CompletableFuture.allOf(
stopTaskMonitorFuture,
stopConnectionMonitorFuture,
stopLaunchCoordinatorFuture,
stopReconciliationCoordinatorFuture);
+ }
+
+ @Override
+ public CompletableFuture<Void> postStop() {
+ final CompletableFuture<Void> supportActorsStopFuture =
stopSupportingActorsAsync();
final CompletableFuture<Void> terminationFuture =
super.postStop();
Review comment:
I think we should call `super.postStop` only after `supportActorsStopFuture`
has been completed. Otherwise we might risk that the parent class shuts some
resources down which are used by the support actors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
