[
https://issues.apache.org/jira/browse/FLINK-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573302#comment-16573302
]
ASF GitHub Bot commented on FLINK-10063:
----------------------------------------
GJL commented on a change in pull request #6496: [FLINK-10063][tests] Use runit
to supervise mesos processes.
URL: https://github.com/apache/flink/pull/6496#discussion_r208608118
##########
File path: flink-jepsen/docker/Dockerfile-db
##########
@@ -35,5 +35,12 @@ RUN mkdir -p /root/.ssh/ && \
chmod 600 /root/.ssh/authorized_keys && \
cat /root/id_rsa.pub >> /root/.ssh/authorized_keys
+COPY sshd-run /etc/sv/service/sshd/run
+RUN chmod +x /etc/sv/service/sshd/run && \
+ ln -sf /etc/sv/service/sshd /etc/service
+
EXPOSE 22
-CMD exec /usr/sbin/sshd -D
+
+# Start runit process supervisor which will bring up sshd.
+# In our tests we can use runit to supervise more processes, e.g., Mesos.
+CMD runsvdir -P /etc/service /dev/null > /dev/null
Review comment:
Yes is needed. It only redirects std err:
> If the log argument is given to runsvdir, all output to standard error is
redirected to this log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Jepsen: Automatically restart Mesos Processes
> ---------------------------------------------
>
> Key: FLINK-10063
> URL: https://issues.apache.org/jira/browse/FLINK-10063
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.6.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0
>
>
> Use a process supervisor to automatically restart Mesos processes. This is
> needed because Mesos uses a "fail-fast" approach to error handling, e.g., the
> Mesos master will exit when it discovers it has been partitioned away from
> the Zookeeper quorum. Currently the some of the tests cannot pass because the
> Mesos processes exiting.
> *Acceptance Criteria*
> * Running tests with {{--deployment-mode mesos-session}} should not fail due
> to reasons related to the Mesos setup.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
