[
https://issues.apache.org/jira/browse/FLINK-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573409#comment-16573409
]
ASF GitHub Bot commented on FLINK-9899:
---------------------------------------
glaksh100 commented on a change in pull request #6409: [FLINK-9899][Kinesis
Connector] Add comprehensive per-shard metrics to ShardConsumer
URL: https://github.com/apache/flink/pull/6409#discussion_r208635417
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/metrics/ShardMetricsReporter.java
##########
@@ -28,14 +28,14 @@
public class ShardMetricsReporter {
private volatile long millisBehindLatest = -1;
- private volatile double loopFrequencyHz = 0.0;
- private volatile double bytesPerRead = 0.0;
- private volatile long runLoopTimeNanos = 0L;
- private volatile long averageRecordSizeBytes = 0L;
- private volatile long sleepTimeMillis = 0L;
- private volatile int numberOfAggregatedRecords = 0;
- private volatile int numberOfDeaggregatedRecords = 0;
- private volatile int maxNumberOfRecordsPerFetch = 0;
+ private volatile double loopFrequencyHz = -1.0;
+ private volatile double bytesPerRead = -1.0;
+ private volatile long runLoopTimeNanos = -1;
+ private volatile long averageRecordSizeBytes = -1;
+ private volatile long sleepTimeMillis = -1;
Review comment:
Agreed that they can mess with aggregations. I changed the default values to
0 and made corresponding doc updates.
Note: `millisBehindLatest` (not a part of this PR) has a default value of
-1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add more metrics to the Kinesis source connector
> ------------------------------------------------
>
> Key: FLINK-9899
> URL: https://issues.apache.org/jira/browse/FLINK-9899
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Affects Versions: 1.4.2, 1.5.1
> Reporter: Lakshmi Rao
> Assignee: Lakshmi Rao
> Priority: Major
> Labels: pull-request-available
>
> Currently there are sparse metrics available for the Kinesis Connector. Using
> the
> [ShardMetricsReporter|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/metrics/ShardMetricsReporter.java]
> add more stats. For example:
> - sleepTimeMillis
> - maxNumberOfRecordsPerFetch
> - numberOfAggregatedRecordsPerFetch
> - numberOfDeaggregatedRecordsPerFetch
> - bytesPerFetch
> - averageRecordSizeBytes
> - runLoopTimeNanos
> - loopFrequencyHz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
