Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/966#discussion_r36357066
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/io/ReplicatingInputFormat.java
 ---
    @@ -59,7 +60,7 @@
      * @see org.apache.flink.api.common.operators.base.FilterOperatorBase
      * @see org.apache.flink.api.common.operators.base.MapPartitionOperatorBase
      */
    -public final class ReplicatingInputFormat<OT, S extends InputSplit> 
implements InputFormat<OT, S> {
    +public final class ReplicatingInputFormat<OT, S extends InputSplit> 
extends RichInputFormat<OT, S> {
    --- End diff --
    
    The `ReplicatingInputFormat` can wrap any kind of `InputFormat` (with or 
without RuntimeContext). 
    Therefore, it needs to extend `RichInputFormat` but overwrite the 
`setRuntimeContext()` method and forward the context to its wrapped IF, if this 
is also a `RichInputFormat`.
    
    Please check the updated JavaDocs as well. The wrapped IF does not need to 
be rich.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to