maqingxiang commented on a change in pull request #5304: [FLINK-8290]Modify 
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r209480301
 
 

 ##########
 File path: 
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
 ##########
 @@ -123,6 +124,7 @@ public SimpleConsumerThread(
                this.fetchSize = getInt(config, "fetch.message.max.bytes", 
1048576);
                this.bufferSize = getInt(config, "socket.receive.buffer.bytes", 
65536);
                this.reconnectLimit = getInt(config, 
"flink.simple-consumer-reconnectLimit", 3);
+               this.clientId = config.getProperty("group.id", 
"flink-kafka-consumer-legacy-" + broker.id());
 
 Review comment:
   The way that @azagrebin is suggesting is really my initially suggested, but 
` "flink-kafka-consumer-legacy-" + broker.id() ` has not been in effect.  
   
   I'm a little confused now, how do I set it up better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to