azagrebin commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r209553402
##########
File path:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
##########
@@ -123,6 +124,7 @@ public SimpleConsumerThread(
this.fetchSize = getInt(config, "fetch.message.max.bytes",
1048576);
this.bufferSize = getInt(config, "socket.receive.buffer.bytes",
65536);
this.reconnectLimit = getInt(config,
"flink.simple-consumer-reconnectLimit", 3);
+ this.clientId = config.getProperty("group.id",
"flink-kafka-consumer-legacy-" + broker.id());
Review comment:
I think we can just replace this line in the current PR:
```
this.clientId = config.getProperty("group.id",
"flink-kafka-consumer-legacy-" + broker.id());
```
with these 2 lines:
```
String groupId = config.getProperty("group.id",
"flink-kafka-consumer-legacy-" + broker.id());
this.clientId = config.getProperty("client.id", groupId);
```
`Group id` will be default value for `client id` then, as in Kafka docs, but
user can change both of them independently if user ever needs it. It should
also help in logs with multiple topics.
`"flink-kafka-consumer-legacy-" + broker.id()` will be just default value
for `group.id`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
