zentol commented on a change in pull request #6551:
[FLINK-10022][network][metrics] add metrics for input/output buffers
URL: https://github.com/apache/flink/pull/6551#discussion_r209932565
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
##########
@@ -43,38 +43,74 @@
protected double numBytesInRemotePerSecond;
protected double numBytesOutPerSecond;
- public IOMetrics(Meter recordsIn, Meter recordsOut, Meter bytesLocalIn,
Meter bytesRemoteIn, Meter bytesOut) {
+ protected long numBuffersInLocal;
+ protected long numBuffersInRemote;
+ protected long numBuffersOut;
+
+ protected double numBuffersInLocalPerSecond;
+ protected double numBuffersInRemotePerSecond;
+ protected double numBuffersOutPerSecond;
+
+ public IOMetrics(
Review comment:
it should be fine to remove them from this class, and revert the changes to
the various handlers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
