[jira] [Commented] (FLINK-10145) Add replace supported in TableAPI and SQL

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585023#comment-16585023
 ] 

ASF GitHub Bot commented on FLINK-10145:
----------------------------------------

yanghua commented on a change in pull request #6576: [FLINK-10145][table] Add 
replace supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6576#discussion_r211091900
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -2592,6 +2604,18 @@ STRING.substring(INT1, INT2)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight java %}
+STRING.replace(STRING1, STRING2)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns a new string from <i>STRING</i> replaced 
<i>STRING1</i>(non-overlapping) with <i>STRING2</i>.</p>
+        <p>E.g., <code>'hello world'.replace('world', 'flink')</code> returns 
'hello flink'; <code>'ababab'.replace('abab', 'z')</code> returns "zab"</p>
 
 Review comment:
   replace all '' to ""

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add replace supported in TableAPI and SQL
> -----------------------------------------
>
>                 Key: FLINK-10145
>                 URL: https://issues.apache.org/jira/browse/FLINK-10145
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Guibo Pan
>            Assignee: Guibo Pan
>            Priority: Major
>              Labels: pull-request-available
>
> replace is an useful function for String. 
> for example:
> {code:java}
> select replace("Hello World", "World", "Flink") // return "Hello Flink"
> select replace("ababab", "abab", "z") // return "zab"
> {code}
> It is supported as a UDF in Hive, more details please see[1]
> [1]: 
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-StringFunctions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)