pnowojski commented on a change in pull request #6355:
[FLINK-9878][network][ssl] add more low-level ssl options
URL: https://github.com/apache/flink/pull/6355#discussion_r211285792
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java
##########
@@ -98,21 +86,48 @@ public void testValidSslConnectionAdvanced() throws
Exception {
Channel ch = NettyTestUtil.connect(serverAndClient);
SslHandler sslHandler = (SslHandler) ch.pipeline().get("ssl");
- assertEquals(sslHandler.getHandshakeTimeoutMillis(),
handshakeTimeout);
- assertEquals(sslHandler.getCloseNotifyTimeoutMillis(),
closeNotifyFlushTimeout);
+ int handshakeTimeout =
sslConfig.getInteger(SSL_HANDSHAKE_TIMEOUT);
Review comment:
```
assertSslConfig(sslConfig.getInteger(SSL_HANDSHAKE_TIMEOUT),
sslHandler.getHandshakeTimeoutMillis())
```
and do:
```
assertSslConfig(expected, actual) {
if (expected != -1) {
assertEquals(expected, actual)
}
else {
assertTrue(...);
}
}
```
in 4 places here? Maybe renaming it to `assertEqualsOrMinusAsDefaultValue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
