fhueske commented on a change in pull request #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser URL: https://github.com/apache/flink/pull/6585#discussion_r211326743
########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/CalcStringExpressionTest.scala ########## @@ -85,6 +85,39 @@ class CalcStringExpressionTest extends TableTestBase { verifyTableEquals(t1, t2) } + @Test + def testSelectWithOrdering(): Unit = { Review comment: Can you move these tests into a new class `SortStringExpressionTest`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services