[
https://issues.apache.org/jira/browse/FLINK-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586182#comment-16586182
]
ASF GitHub Bot commented on FLINK-10172:
----------------------------------------
fhueske commented on a change in pull request #6585:
[FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser
URL: https://github.com/apache/flink/pull/6585#discussion_r211326743
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/CalcStringExpressionTest.scala
##########
@@ -85,6 +85,39 @@ class CalcStringExpressionTest extends TableTestBase {
verifyTableEquals(t1, t2)
}
+ @Test
+ def testSelectWithOrdering(): Unit = {
Review comment:
Can you move these tests into a new class `SortStringExpressionTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc
> --------------------------------------------------------------------------
>
> Key: FLINK-10172
> URL: https://issues.apache.org/jira/browse/FLINK-10172
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
> Labels: pull-request-available
>
> The following expression throws an exception in parsing {{"id.asc"}} term.
> {code:java}
> Table allOrders = orderTable
> .select("id,order_date,amount,customer_id")
> .orderBy("id.asc");
> {code}
> while it is correctly parsed for Scala:
> {code:scala}
> val allOrders:Table = orderTable
> .select('id, 'order_date, 'amount, 'customer_id)
> .orderBy('id.asc)
> {code}
> Anticipated some inconsistency between ExpressionParser and ExpressionDsl
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
