Github user ChengXiangLi commented on the pull request:

    https://github.com/apache/flink/pull/949#issuecomment-128580607
  
    Hi, @tillrohrmann , current implementation of sample with fixed size would 
generate fixed size sample for each partition randomly instead of the whole 
dataset, user may expect the later one actually most of the time. I'm research 
on how to sample fixed size elements randomly from distributed data stream, i 
think we can pause this PR review until i merge the previous fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to