yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 
connectors
URL: https://github.com/apache/flink/pull/6577#issuecomment-414951008
 
 
   @pnowojski I am refactoring the code to reduce unnecessary code. 
   
   Actually, the change from kafka v0.11 to v1.0, Not just a variable, there 
are some tests code that are not available, see 
[here](https://github.com/apache/flink/pull/6577/files#diff-527838fe63568e530d871d45a98e3fe4R157)
 and 
[here](https://github.com/apache/flink/pull/6577/files#diff-527838fe63568e530d871d45a98e3fe4R168).
 Some [old methods about using Zookeeper to get 
metadata](https://github.com/apache/kafka/commit/1d24e10aeab616eede416201336e928b9a8efa98#commitcomment-30035522)
 which are not available.
   
   for the third point, according @aljoscha 's 
[comment](https://issues.apache.org/jira/browse/FLINK-10067?focusedCommentId=16571628&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16571628),
 I think we also need a new connector for kafka v1.1 to categorize the problems 
encountered by different kafka versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to