pnowojski commented on a change in pull request #6574: [FLINK-8868] [table]
Support Table Function as Table Source for Stream Sql
URL: https://github.com/apache/flink/pull/6574#discussion_r212213682
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
##########
@@ -897,6 +897,45 @@ class SqlITCase extends StreamingWithStateTestBase {
assertEquals(List(expected.toString()), StreamITCase.testResults.sorted)
}
+
+ @Test
Review comment:
What's the problem with Table API here? I had a suspicion that this
`ValidationException`:
```
def getRelNode: RelNode = if (containsUnboundedUDTFCall(logicalPlan)) {
throw new ValidationException("Cannot translate a query with an
unbounded table function call.")
} else {
logicalPlan.toRelNode(relBuilder)
}
```
is being thrown mostly as a precaution, since previously there was no
execution code to support it. Now (with this PR) that will not be the case
anymore. What would happen if we simply removed it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
