StephanEwen commented on issue #6608: [FLINK-10203]Support truncate method for 
old Hadoop versions in HadoopRecoverableFsDataOutputStream
URL: https://github.com/apache/flink/pull/6608#issuecomment-415507439
 
 
   I see, that is a fair reason. There are parallel efforts to add Parquet 
support to the old BucketingSink, but I see the point.
   
   Before going into a deep review,  can you update the description with how 
exactly the legacy truncater should be working: what copy and rename steps it 
does and how it behaves under failure / repeated calls. 
   
   Also, I would suggest to name it `Truncater` rather than `TruncateManager`. 
Too many managers all around already ;-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to