[
https://issues.apache.org/jira/browse/FLINK-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592563#comment-16592563
]
ASF GitHub Bot commented on FLINK-10172:
----------------------------------------
fhueske commented on a change in pull request #6585:
[FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser
URL: https://github.com/apache/flink/pull/6585#discussion_r212797015
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
##########
@@ -324,6 +332,8 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
suffixToDate |
// expression for log
suffixLog |
+ // expression for ordering
+ suffixAsc | suffixDesc |
Review comment:
Naming the function `asicii` does not sound right to me. I'd never look for
this name if I'd was looking for ASCII conversion. There should be a proper fix
for this.
Please move this discussion to the ascii function PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc
> --------------------------------------------------------------------------
>
> Key: FLINK-10172
> URL: https://issues.apache.org/jira/browse/FLINK-10172
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.3.3, 1.4.2, 1.5.3, 1.6.0, 1.7.0
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.3, 1.4.3, 1.6.1, 1.7.0, 1.5.4
>
>
> The following expression throws an exception in parsing {{"id.asc"}} term.
> {code:java}
> Table allOrders = orderTable
> .select("id,order_date,amount,customer_id")
> .orderBy("id.asc");
> {code}
> while it is correctly parsed for Scala:
> {code:scala}
> val allOrders:Table = orderTable
> .select('id, 'order_date, 'amount, 'customer_id)
> .orderBy('id.asc)
> {code}
> Anticipated some inconsistency between ExpressionParser and ExpressionDsl
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
