[jira] [Commented] (FLINK-2458) Distributed Cache doesn't work with iterations.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661728#comment-14661728
 ] 

ASF GitHub Bot commented on FLINK-2458:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/970#discussion_r36512186
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/functions/util/RuntimeUDFContext.java
 ---
    @@ -37,18 +37,17 @@
        private final HashMap<String, Object> initializedBroadcastVars = new 
HashMap<String, Object>();
        
        private final HashMap<String, List<?>> uninitializedBroadcastVars = new 
HashMap<String, List<?>>();
    -   
    -   
    +
        public RuntimeUDFContext(String name, int numParallelSubtasks, int 
subtaskIndex, ClassLoader userCodeClassLoader,
                                                        ExecutionConfig 
executionConfig, Map<String, Accumulator<?,?>> accumulators) {
    -           super(name, numParallelSubtasks, subtaskIndex, 
userCodeClassLoader, executionConfig, accumulators);
    +           this(name, numParallelSubtasks, subtaskIndex, 
userCodeClassLoader, executionConfig,
    +                           new HashMap<String, Future<Path>>(), 
accumulators);
        }
    -   
    +
        public RuntimeUDFContext(String name, int numParallelSubtasks, int 
subtaskIndex, ClassLoader userCodeClassLoader,
                                                        ExecutionConfig 
executionConfig, Map<String, Future<Path>> cpTasks, Map<String, 
Accumulator<?,?>> accumulators) {
                super(name, numParallelSubtasks, subtaskIndex, 
userCodeClassLoader, executionConfig, accumulators, cpTasks);
        }
    -   
    --- End diff --
    
    Here we have a few unnecessary formatting changes that just clutter the 
diff.


> Distributed Cache doesn't work with iterations.
> -----------------------------------------------
>
>                 Key: FLINK-2458
>                 URL: https://issues.apache.org/jira/browse/FLINK-2458
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> Distributed cache files cannot be accessed when working in Iterative 
> contexts. While constructing the context in {{AbstractIterativePactTask}}, 
> the distributed entries are not passed on to runtime context.
> My commit will add this and also unify the distributed cache system to work 
> everywhere, including in the Collection Environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)