zhijiangW commented on a change in pull request #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#discussion_r213345034
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializerTest.java ########## @@ -169,25 +167,26 @@ private void test(Util.MockRecords records, int segmentSize) throws Exception { // ------------------------------------------------------------------------------------------------------------- - serializer.continueWritingWithNextBufferBuilder(createBufferBuilder(segmentSize)); - + BufferBuilder bufferBuilder = createBufferBuilder(segmentSize); int numBytes = 0; for (SerializationTestType record : records) { - RecordSerializer.SerializationResult result = serializer.addRecord(record); + serializer.serializeRecord(record); + RecordSerializer.SerializationResult result = serializer.copyToBufferBuilder(bufferBuilder); numBytes += record.length() + serializationOverhead; if (numBytes < segmentSize) { Assert.assertEquals(RecordSerializer.SerializationResult.FULL_RECORD, result); } else if (numBytes == segmentSize) { Assert.assertEquals(RecordSerializer.SerializationResult.FULL_RECORD_MEMORY_SEGMENT_FULL, result); - serializer.continueWritingWithNextBufferBuilder(createBufferBuilder(segmentSize)); + bufferBuilder = createBufferBuilder(segmentSize); numBytes = 0; } else { Assert.assertEquals(RecordSerializer.SerializationResult.PARTIAL_RECORD_MEMORY_SEGMENT_FULL, result); while (result.isFullBuffer()) { numBytes -= segmentSize; - result = serializer.continueWritingWithNextBufferBuilder(createBufferBuilder(segmentSize)); + bufferBuilder = createBufferBuilder(segmentSize); + result = serializer.copyToBufferBuilder(bufferBuilder); Review comment: make sense ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services