zentol closed pull request #4482: [FLINK-4534] Fix synchronization issue in
BucketingSink
URL: https://github.com/apache/flink/pull/4482
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
index faf3c566803..2472387ed44 100644
---
a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
+++
b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
@@ -422,9 +422,11 @@ private void initFileSystem() throws IOException {
@Override
public void close() throws Exception {
- if (state != null) {
- for (Map.Entry<String, BucketState<T>> entry :
state.bucketStates.entrySet()) {
- closeCurrentPartFile(entry.getValue());
+ synchronized (state.bucketStates) {
+ if (state != null) {
+ for (Map.Entry<String, BucketState<T>> entry :
state.bucketStates.entrySet()) {
+ closeCurrentPartFile(entry.getValue());
+ }
}
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
