[
https://issues.apache.org/jira/browse/FLINK-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596523#comment-16596523
]
ASF GitHub Bot commented on FLINK-10254:
----------------------------------------
azagrebin commented on a change in pull request #6632:
[FLINK-10254][backend]Fix inappropriate checkNotNull in stateBackend
URL: https://github.com/apache/flink/pull/6632#discussion_r213735414
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
##########
@@ -100,9 +100,11 @@ public AbstractKeyedStateBackend(
ExecutionConfig executionConfig,
TtlTimeProvider ttlTimeProvider) {
+ Preconditions.checkArgument(numberOfKeyGroups >= 1,
"NumberOfKeyGroups must be a positive number");
Review comment:
We can also add this:
```
Preconditions.checkArgument(numberOfKeyGroups >=
keyGroupRange.getNumberOfKeyGroups(), "The total number of key groups must be
at least the number in the key group range assigned to this backend");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix inappropriate checkNotNull in stateBackend
> ----------------------------------------------
>
> Key: FLINK-10254
> URL: https://issues.apache.org/jira/browse/FLINK-10254
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: aitozi
> Assignee: aitozi
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The checkNotNull is unnecessary of numberOfKeyGroups with a primitive type ,
> we just have to make sure it is bigger than 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
