[ https://issues.apache.org/jira/browse/FLINK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596804#comment-16596804 ]
ASF GitHub Bot commented on FLINK-10207: ---------------------------------------- zentol closed pull request #6618: [FLINK-10207][build] Bump checkstyle to 8.9 URL: https://github.com/apache/flink/pull/6618 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/flinkDev/ide_setup.md b/docs/flinkDev/ide_setup.md index 66cd552a0b5..87e7ceb5e99 100644 --- a/docs/flinkDev/ide_setup.md +++ b/docs/flinkDev/ide_setup.md @@ -87,7 +87,7 @@ IntelliJ supports checkstyle within the IDE using the Checkstyle-IDEA plugin. 1. Install the "Checkstyle-IDEA" plugin from the IntelliJ plugin repository. 2. Configure the plugin by going to Settings -> Other Settings -> Checkstyle. 3. Set the "Scan Scope" to "Only Java sources (including tests)". -4. Select _8.4_ in the "Checkstyle Version" dropdown and click apply. **This step is important, +4. Select _8.9_ in the "Checkstyle Version" dropdown and click apply. **This step is important, don't skip it!** 5. In the "Configuration File" pane, add a new configuration using the plus icon: 1. Set the "Description" to "Flink". diff --git a/flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java b/flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java index ec9cfc548c1..a83f29cb6b5 100644 --- a/flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java +++ b/flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java @@ -60,6 +60,9 @@ import java.util.Collections; import java.util.UUID; +import scala.concurrent.Await; +import scala.concurrent.duration.Duration; + import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.fail; @@ -67,9 +70,6 @@ import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; -import scala.concurrent.Await; -import scala.concurrent.duration.Duration; - /** * Simple and maybe stupid test to check the {@link ClusterClient} class. */ diff --git a/flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java b/flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java index 4f77f954d3e..3d6c5837e97 100644 --- a/flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java +++ b/flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java @@ -29,15 +29,15 @@ import org.apache.flink.streaming.api.functions.sink.PrintSinkFunction; import org.apache.flink.streaming.tests.artificialstate.ComplexPayload; +import java.util.Collections; +import java.util.List; + import static org.apache.flink.streaming.tests.DataStreamAllroundTestJobFactory.createArtificialKeyedStateMapper; import static org.apache.flink.streaming.tests.DataStreamAllroundTestJobFactory.createEventSource; import static org.apache.flink.streaming.tests.DataStreamAllroundTestJobFactory.createSemanticsCheckMapper; import static org.apache.flink.streaming.tests.DataStreamAllroundTestJobFactory.createTimestampExtractor; import static org.apache.flink.streaming.tests.DataStreamAllroundTestJobFactory.setupEnvironment; -import java.util.Collections; -import java.util.List; - /** * Test upgrade of generic stateful job for Flink's DataStream API operators and primitives. * diff --git a/flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java b/flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java index cd371216586..784a50eeb70 100644 --- a/flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java +++ b/flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java @@ -26,12 +26,12 @@ import org.junit.Rule; import org.junit.rules.TemporaryFolder; -import static org.junit.Assert.fail; - import java.io.FileInputStream; import java.io.IOException; import java.util.Properties; +import static org.junit.Assert.fail; + /** * Base class for tests for {@link ParameterTool}. */ diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/impl/AkkaJobManagerRetrieverTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/impl/AkkaJobManagerRetrieverTest.java index 53145504ec8..35fa7b82a02 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/impl/AkkaJobManagerRetrieverTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/impl/AkkaJobManagerRetrieverTest.java @@ -39,11 +39,11 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; +import scala.concurrent.Await; + import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; -import scala.concurrent.Await; - /** * Test for the {@link AkkaJobManagerRetriever}. */ diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnTaskManagerRunnerFactoryTest.java b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnTaskManagerRunnerFactoryTest.java index 7f518f14092..f23b256bbdc 100644 --- a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnTaskManagerRunnerFactoryTest.java +++ b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnTaskManagerRunnerFactoryTest.java @@ -27,9 +27,6 @@ import org.apache.hadoop.yarn.api.ApplicationConstants; import org.junit.Test; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.fail; - import java.io.IOException; import java.nio.file.Paths; import java.util.HashMap; @@ -37,6 +34,9 @@ import java.util.Map; import java.util.Optional; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; + /** * Tests for {@link YarnTaskManagerRunnerFactory}. */ diff --git a/pom.xml b/pom.xml index f11e8ff1506..314e7956513 100644 --- a/pom.xml +++ b/pom.xml @@ -1387,7 +1387,7 @@ under the License. <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> <!-- Note: match version with docs/internals/ide_setup.md --> - <version>8.4</version> + <version>8.9</version> </dependency> </dependencies> <executions> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bump checkstyle-plugin to 8.9 > ----------------------------- > > Key: FLINK-10207 > URL: https://issues.apache.org/jira/browse/FLINK-10207 > Project: Flink > Issue Type: Sub-task > Components: Build System > Affects Versions: 1.7.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Our current checkstyle version (8.4) is incompatible with java 9, the > earliest version to work properly is 8.9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)