[
https://issues.apache.org/jira/browse/FLINK-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605604#comment-16605604
]
ASF GitHub Bot commented on FLINK-10208:
----------------------------------------
NicoK commented on a change in pull request #6634: [FLINK-10208][build] Bump
mockito to 2.21.0 / powermock to 2.0.0-beta.5
URL: https://github.com/apache/flink/pull/6634#discussion_r215573439
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTestBase.java
##########
@@ -531,7 +532,7 @@ public void testMultiChannelSkippingCheckpoints() throws
Exception {
// checkpoint 3 aborted (end of partition)
check(sequence[20], buffer.getNextNonBlocked(), PAGE_SIZE);
- verify(toNotify).abortCheckpointOnBarrier(eq(3L),
any(CheckpointDeclineSubsumedException.class));
+ verify(toNotify).abortCheckpointOnBarrier(eq(3L),
any(InputEndOfStreamException.class));
Review comment:
Actually, that code has been around before @zhijiangW last touched it, but
old and new do not actually verify the intended behaviour, i.e. "check that
there was a call `abortCheckpointOnBarrier(3L, InputEndOfStreamException)`".
If you look at the JavaDocs of `any`, it also reveals why:
> Any kind object, not necessary of the given class.
> The class argument is provided only to avoid casting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bump mockito to 2.0+
> --------------------
>
> Key: FLINK-10208
> URL: https://issues.apache.org/jira/browse/FLINK-10208
> Project: Flink
> Issue Type: Sub-task
> Components: Build System, Tests
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Mockito only properly supports java 9 with version 2. We have to bump the
> dependency and fix various API incompatibilities.
> Additionally we could investigate whether we still need powermock after
> bumping the dependency (which we'd also have to bump otherwise).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
