twalthr commented on a change in pull request #6648: [FLINK-10261][table] fix
insert into with order by
URL: https://github.com/apache/flink/pull/6648#discussion_r215628550
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/validation/SortValidationTest.scala
##########
@@ -54,4 +53,12 @@ class SortValidationTest extends TableTestBase {
val sqlQuery = "SELECT a FROM MyTable LIMIT 3"
streamUtil.verifySql(sqlQuery, "")
}
+
+ // test should fail because time is not order field
+ @Test(expected = classOf[TableException])
+ def testNonTimeSorting(): Unit = {
Review comment:
This test is not testing what it is supposed to test. I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
