NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216249203
########## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java ########## @@ -115,7 +115,8 @@ public void setUp( int channels, boolean localMode, int senderBufferPoolSize, - int receiverBufferPoolSize) throws Exception { + int receiverBufferPoolSize, + Configuration config) throws Exception { Review comment: sure, why not (I'm backporting this patch to Flink 1.5+ anyway, but not all tags) -> did the same for the other `setUp()` methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services