[
https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611646#comment-16611646
]
ASF GitHub Bot commented on FLINK-10319:
----------------------------------------
yanghua commented on issue #6680: [FLINK-10319] [runtime] Avoid
requestPartitionState from JM but alway…
URL: https://github.com/apache/flink/pull/6680#issuecomment-420525893
@TisonKun thanks for your contribution, Travis task all failed, one of them
showed these errors :
```
04:02:28.212 [ERROR]
/home/travis/build/apache/flink/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java:[280,30]
org.apache.flink.streaming.runtime.io.benchmark.StreamNetworkBenchmarkEnvironment.NoOpTaskActions
is not abstract and does not override abstract method
triggerPartitionProducerStateCheck(org.apache.flink.runtime.jobgraph.IntermediateDataSetID,org.apache.flink.runtime.io.network.partition.ResultPartitionID)
in org.apache.flink.runtime.taskmanager.TaskActions
04:02:28.212 [ERROR]
/home/travis/build/apache/flink/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java:[282,17]
method does not override or implement a method from a supertype
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avoid requestPartitionState from JM but always try retrigger
> ------------------------------------------------------------
>
> Key: FLINK-10319
> URL: https://issues.apache.org/jira/browse/FLINK-10319
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.7.0
> Reporter: 陈梓立
> Assignee: 陈梓立
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Do not requestPartitionState from JM on partition request fail, which may
> generate too many RPC requests and block JM.
> We gain little benefit to check what state producer is in, which in the other
> hand crash JM by too many RPC requests. Task could always
> retriggerPartitionRequest from its InputGate, it would be fail if the
> producer has gone and succeed if the producer alive. Anyway, no need to ask
> for JM for help.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
