xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add
regexp_replace supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6450#discussion_r216955992
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
##########
@@ -550,6 +550,45 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"1111111111111111111111111111111111111111111111111111111111111111")
}
+ @Test
+ def testRegexpReplace(): Unit = {
Review comment:
Add a test for no matching (the original string should be unchanged). Also,
test some special replacement strings such as "$" and "\\".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
