[
https://issues.apache.org/jira/browse/FLINK-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611865#comment-16611865
]
ASF GitHub Bot commented on FLINK-10324:
----------------------------------------
tillrohrmann opened a new pull request #6681: [FLINK-10324] Replace
ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock
URL: https://github.com/apache/flink/pull/6681
## What is the purpose of the change
In order to reduce code duplication this commit replaces
ZooKeeperStateHandleStore#
getAllSortedByNameAndLock by getAllAndLock and do the sorting of the entries
afterwards.
The implication of this change is that we no longer try to release and
remove corrupted
entries and instead simply ignore them.
## Verifying this change
Covered by existing `ZooKeeperStateHandleStore` tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock
> ----------------------------------------------------------------------------
>
> Key: FLINK-10324
> URL: https://issues.apache.org/jira/browse/FLINK-10324
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> In order to reduce code duplication I propose to replace
> {{ZooKeeperStateHandleStore#getAllSortedByNameAndLock}} by
> {{ZooKeeperStateHandleStore#getAllAndLock}} and sort afterwards.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
