[ 
https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612093#comment-16612093
 ] 

ASF GitHub Bot commented on FLINK-10205:
----------------------------------------

isunjin opened a new pull request #6684:     [FLINK-10205] Batch Job: 
InputSplit Fault tolerant for DataSource…
URL: https://github.com/apache/flink/pull/6684
 
 
   ## What is the purpose of the change
   
       Today DataSource Task pull InputSplits from JobManager to achieve better
       performance, however, when a DataSourceTask failed and rerun, it will
       not get the same splits as its previous version. this will introduce
       inconsistent result or even data corruption.
   
       Furthermore,  if there are two executions run at the same time (in batch
       scenario), this two executions should process same splits.
   
       we need to fix the issue to make the inputs of a DataSourceTask
       deterministic. The propose is save all splits into ExecutionVertex and
       DataSourceTask will pull split from there.
   
   
   ## Brief change log
   
     - *JobMaster getNextInputSplit from Execution*
     - *Execution forward getNextInputSplit and the sequence number of the 
request to ExecutionVertex*
     - *If the sequence number exist in the ExecutionVertex return, else 
calculate and cache*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *covered by existing test*
     - *Added a new test that validates the scenario that getNextInputSplit 
multiple times with different Execution attempts per ExecutionVertex*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Batch Job: InputSplit Fault tolerant for DataSourceTask
> -------------------------------------------------------
>
>                 Key: FLINK-10205
>                 URL: https://issues.apache.org/jira/browse/FLINK-10205
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager
>            Reporter: JIN SUN
>            Assignee: JIN SUN
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Today DataSource Task pull InputSplits from JobManager to achieve better 
> performance, however, when a DataSourceTask failed and rerun, it will not get 
> the same splits as its previous version. this will introduce inconsistent 
> result or even data corruption.
> Furthermore,  if there are two executions run at the same time (in batch 
> scenario), this two executions should process same splits.
> we need to fix the issue to make the inputs of a DataSourceTask 
> deterministic. The propose is save all splits into ExecutionVertex and 
> DataSourceTask will pull split from there.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to