[ https://issues.apache.org/jira/browse/FLINK-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613561#comment-16613561 ]
ASF GitHub Bot commented on FLINK-10321: ---------------------------------------- TisonKun commented on issue #6688: [FLINK-10321][network] Simplify the condition of BroadcastPartitioner URL: https://github.com/apache/flink/pull/6688#issuecomment-421024900 FYI, travis fails by irrelevant issue. ``` Status: Downloaded newer image for java:8-jre-alpine ---> fdc893b19a14 Step 2/16 : RUN apk add --no-cache bash snappy ---> [Warning] IPv4 forwarding is disabled. Networking will not work. ---> Running in 04ebab036ceb fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/main/x86_64/APKINDEX.tar.gz WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.4/main/x86_64/APKINDEX.tar.gz: temporary error (try again later) fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/community/x86_64/APKINDEX.tar.gz WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.4/community/x86_64/APKINDEX.tar.gz: temporary error (try again later) ERROR: unsatisfiable constraints: bash (missing): required by: world[bash] snappy (missing): required by: world[snappy] The command '/bin/sh -c apk add --no-cache bash snappy' returned a non-zero code: 2 No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated ``` @zentol is it something wrong on travis or our script? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make the condition of broadcast partitioner simple > -------------------------------------------------- > > Key: FLINK-10321 > URL: https://issues.apache.org/jira/browse/FLINK-10321 > Project: Flink > Issue Type: Improvement > Components: Network > Affects Versions: 1.7.0 > Reporter: zhijiang > Assignee: zhijiang > Priority: Minor > Labels: pull-request-available > > The current {{BroadcastPartitioner}} uses the vars of {{set}} and > {{setNumber}} as the condition for returning channel arrays. > Instead of using {{set}} and {{setNumber}}, we can just check whether > {{returnChannel.length == numberOfOutputChannels}} as the condition to make > it simple. -- This message was sent by Atlassian JIRA (v7.6.3#76005)