[
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614755#comment-16614755
]
ASF GitHub Bot commented on FLINK-9713:
---------------------------------------
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217373861
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
##########
@@ -155,6 +156,50 @@ class Table(
select(withResolvedAggFunctionCall: _*)
}
+ /**
+ * Creates [[TemporalTableFunction]] backed up by this table as a history
table.
+ *
+ * @param timeIndicator field for the [[TemporalTableFunction]]. Must
points to a time indicator
+ * @param primaryKey field for the [[TemporalTableFunction]].
+ * @return [[TemporalTableFunction]]
+ */
+ def createTemporalTableFunction(
+ timeIndicator: String,
+ primaryKey: String): TemporalTableFunction = {
+ createTemporalTableFunction(
+ ExpressionParser.parseExpression(timeIndicator),
+ ExpressionParser.parseExpression(primaryKey))
+ }
+
+ /**
+ * Creates [[TemporalTableFunction]] backed up by this table as a history
table.
+ *
+ * @param timeIndicator field for the [[TemporalTableFunction]]. Must
points to a time indicator
+ * @param primaryKey field for the [[TemporalTableFunction]].
+ * @return [[TemporalTableFunction]]
+ */
+ def createTemporalTableFunction(
+ timeIndicator: Expression,
+ primaryKey: Expression): TemporalTableFunction = {
+ val temporalTable = new TemporalTable(timeIndicator, primaryKey,
logicalPlan)
+ .validate(tableEnv)
+ .asInstanceOf[TemporalTable]
+
+ TemporalTableFunction.create(
+ this,
+ temporalTable.timeIndicator,
+ validatePrimaryKeyExpression(temporalTable.primaryKey))
+ }
+
+ private def validatePrimaryKeyExpression(expression: Expression): String = {
+ expression match {
+ case fieldReference: ResolvedFieldReference =>
+ fieldReference.name
+ case _ => throw new ValidationException(
+ s"Unsupported expression [${expression}] as primary key")
Review comment:
Add description what is supported as primary key. E.g. "Only single,
top-level field references are supported."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support versioned joins in planning phase
> -----------------------------------------
>
> Key: FLINK-9713
> URL: https://issues.apache.org/jira/browse/FLINK-9713
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT
> o.amount * r.rate
> FROM
> Orders AS o,
> LATERAL TABLE (Rates(o.rowtime)) AS r
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
