[
https://issues.apache.org/jira/browse/FLINK-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620586#comment-16620586
]
ASF GitHub Bot commented on FLINK-10358:
----------------------------------------
tweise commented on issue #6708: [FLINK-10358][Kinesis-connector] fix NPE in
case millisBehindLatest is null
URL: https://github.com/apache/flink/pull/6708#issuecomment-422805054
Looks like it confirms to the spec (the field is not provided for dynamodb
streams - wouldn't make sense either):
https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_streams_GetRecords.html
We are internally using the consumer to process the dynamodb CDC stream,
plan is to add the complete support to the Kinesis connector soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flink kinesis connector could throw NPE during getRecords() call
> -----------------------------------------------------------------
>
> Key: FLINK-10358
> URL: https://issues.apache.org/jira/browse/FLINK-10358
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Reporter: Ying Xu
> Assignee: Ying Xu
> Priority: Major
> Labels: pull-request-available
>
> When extending the flink kinesis connector to consume from a dynamodb stream,
> it was found NPE could be thrown at
> [here|https://github.com/apache/flink/blob/e3c98f05d3544d0165c2d97d2d00fcd295cef8c8/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L376]
> .
> This is because the [getRecords
> API|https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_streams_GetRecords.html]
> in dynamodb streams does not return the millisBehindLatest field and has it
> set to null. Null check is probably needed here.
> See FLINK-4582 for the context of building dynamodb streams connector on top
> of the Kinesis connector.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
