StefanRRichter commented on a change in pull request #6723: [FLINK-10377]
Remove precondition in TwoPhaseCommitSinkFunction.notif…
URL: https://github.com/apache/flink/pull/6723#discussion_r219263435
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
##########
@@ -255,7 +255,6 @@ public final void notifyCheckpointComplete(long
checkpointId) throws Exception {
//
Review comment:
That is a very good point and IIRC, that is the case. Hmm, I see that there
is always an element added in the snapshot method, so one should expect that
there is always one in the notify part because no other method is ever removing
from the map and method calls should also be mutually exclusive because they
both hold the checkpointing lock. What else is left?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
