[
https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623102#comment-16623102
]
ASF GitHub Bot commented on FLINK-10386:
----------------------------------------
TisonKun opened a new pull request #6729: [FLINK-10386] [taskmanager] Remove
legacy class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729
## What is the purpose of the change
After a discussion
[here](https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257)
with @tillrohrmann . I start to analyze the usage of
`ActorGatewayTaskExecutionStateListener` and `TaskExecutionStateListener`.
In conclusion, we abort `TaskExecutionStateListener` strategy and no any
component rely on it. Instead, we introduce `TaskManagerActions` to take the
role for the communication of `Task` with `TaskManager`. No one except
`TaskManager` should directly communicate with `Task`. So it can be safely
remove legacy class `TaskExecutionStateListener`.
## Brief change log
- Wholly Remove `ActorGatewayTaskExecutionStateListener.java` and
`TaskExecutionStateListener.java`
- Graceful remove inactive usage of these class in `Task.java`
- Refine `TaskTest.java` and `StreamTaskTest.java`
## Verifying this change
Since it is a removal, make sure existing tests pass is enough.
cc @tillrohrmann @GJL @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove legacy class TaskExecutionStateListener
> ----------------------------------------------
>
> Key: FLINK-10386
> URL: https://issues.apache.org/jira/browse/FLINK-10386
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Affects Versions: 1.7.0
> Reporter: 陈梓立
> Assignee: 陈梓立
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> After a discussion
> [here|https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257]
> with [~trohrm...@apache.org]. I start to analyze the usage of
> {{ActorGatewayTaskExecutionStateListener}} and {{TaskExecutionStateListener}}.
> In conclusion, we abort {{TaskExecutionStateListener}} strategy and no any
> component rely on it. Instead, we introduce {{TaskManagerActions}} to take
> the role for the communication of {{Task}} with {{TaskManager}}. No one
> except {{TaskManager}} should directly communicate with {{Task}}. So it can
> be safely remove legacy class {{TaskExecutionStateListener}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
