tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219417270
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestServerSSLAuthITCase.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.RestOptions; +import org.apache.flink.configuration.SecurityOptions; +import org.apache.flink.runtime.rest.messages.EmptyMessageParameters; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.EmptyResponseBody; +import org.apache.flink.runtime.rpc.RpcUtils; +import org.apache.flink.runtime.webmonitor.RestfulGateway; +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever; +import org.apache.flink.util.TestLogger; + +import org.apache.flink.shaded.netty4.io.netty.handler.codec.DecoderException; + +import org.junit.Test; + +import javax.net.ssl.SSLHandshakeException; + +import java.util.Arrays; +import java.util.Collections; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.TimeUnit; + +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; +import static org.mockito.Matchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +/** + * This test validates that connections are failing when mutual auth is enabled but untrusted + * keys are used. + */ +public class RestServerSSLAuthITCase extends TestLogger { + + private static final String KEY_STORE_FILE = RestServerSSLAuthITCase.class.getResource("/local127.keystore").getFile(); + private static final String TRUST_STORE_FILE = RestServerSSLAuthITCase.class.getResource("/local127.truststore").getFile(); + private static final String UNTRUSTED_KEY_STORE_FILE = RestServerSSLAuthITCase.class.getResource("/untrusted.keystore").getFile(); + + private static final Time timeout = Time.seconds(10L); + + @Test + public void testConnectFailure() throws Exception { + RestClient restClient = null; + RestServerEndpoint serverEndpoint = null; + + try { + final Configuration baseConfig = new Configuration(); + baseConfig.setInteger(RestOptions.PORT, 0); + baseConfig.setString(RestOptions.ADDRESS, "localhost"); + baseConfig.setBoolean(SecurityOptions.SSL_REST_ENABLED, true); + baseConfig.setBoolean(SecurityOptions.SSL_REST_AUTHENTICATION_ENABLED, true); + baseConfig.setString(SecurityOptions.SSL_ALGORITHMS, "TLS_RSA_WITH_AES_128_CBC_SHA"); + + Configuration serverConfig = new Configuration(baseConfig); + serverConfig.setString(SecurityOptions.SSL_REST_TRUSTSTORE, TRUST_STORE_FILE); + serverConfig.setString(SecurityOptions.SSL_REST_TRUSTSTORE_PASSWORD, "password"); + serverConfig.setString(SecurityOptions.SSL_REST_KEYSTORE, KEY_STORE_FILE); + serverConfig.setString(SecurityOptions.SSL_REST_KEYSTORE_PASSWORD, "password"); + serverConfig.setString(SecurityOptions.SSL_REST_KEY_PASSWORD, "password"); + + Configuration clientConfig = new Configuration(baseConfig); + clientConfig.setString(SecurityOptions.SSL_REST_TRUSTSTORE, UNTRUSTED_KEY_STORE_FILE); + clientConfig.setString(SecurityOptions.SSL_REST_TRUSTSTORE_PASSWORD, "password"); + clientConfig.setString(SecurityOptions.SSL_REST_KEYSTORE, KEY_STORE_FILE); + clientConfig.setString(SecurityOptions.SSL_REST_KEYSTORE_PASSWORD, "password"); + clientConfig.setString(SecurityOptions.SSL_REST_KEY_PASSWORD, "password"); + + RestServerEndpointConfiguration restServerConfig = RestServerEndpointConfiguration.fromConfiguration(serverConfig); + RestClientConfiguration restClientConfig = RestClientConfiguration.fromConfiguration(clientConfig); + + final String restAddress = "http://localhost:1234";; + RestfulGateway mockRestfulGateway = mock(RestfulGateway.class); Review comment: Here you could use the `TestingRestfulGateway`. It also has a builder to make it easy to use. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
