XuQianJin-Stars commented on issue #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed URL: https://github.com/apache/flink/pull/6710#issuecomment-424188954 > I think we need to revisit the way this fix works. At this point, it probably makes sense to close the PR and go back to a design discussion first. I would suggest to have that design discussion on the JIRA issue first. > > (1) Where should the BOM be read? Beginning of the file only? Then it should most likely be part of split generation. > > (2) Any design cannot have additional logic in the method that is called per record, otherwise it will have too much performance impact. @StephanEwen Thank you for your suggestion. I close the PR frist. Then discuss how to fix this bug.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
