pnowojski commented on a change in pull request #6614: [FLINK-9432] [table]
Support extract timeunit: DECADE, EPOCH, ISODOW, ISOYEAR…
URL: https://github.com/apache/flink/pull/6614#discussion_r220154184
##########
File path:
flink-libraries/flink-table/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
##########
@@ -90,6 +90,11 @@ private DateTimeUtils() {}
*/
public static final long MILLIS_PER_DAY = 86400000; // = 24 * 60 * 60 *
1000
+ /**
+ * The number of seconds in a day.
+ */
+ public static final long SECONDS_PER_DAY = 86_400; // = 24 * 60 * 60
Review comment:
Could you change it just to:
```
public static final long SECONDS_PER_DAY = 24 * 60 * 60;
```
Same readability, less duplication. Could you also change it for other
constants in this file like `MILLIS_PER_HOUR` and `MILLIS_PER_DAY`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
