[
https://issues.apache.org/jira/browse/FLINK-9432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627354#comment-16627354
]
ASF GitHub Bot commented on FLINK-9432:
---------------------------------------
pnowojski commented on a change in pull request #6614: [FLINK-9432] [table]
Support extract timeunit: DECADE, EPOCH, ISODOW, ISOYEAR…
URL: https://github.com/apache/flink/pull/6614#discussion_r220154184
##########
File path:
flink-libraries/flink-table/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
##########
@@ -90,6 +90,11 @@ private DateTimeUtils() {}
*/
public static final long MILLIS_PER_DAY = 86400000; // = 24 * 60 * 60 *
1000
+ /**
+ * The number of seconds in a day.
+ */
+ public static final long SECONDS_PER_DAY = 86_400; // = 24 * 60 * 60
Review comment:
Could you change it just to:
```
public static final long SECONDS_PER_DAY = 24 * 60 * 60;
```
Same readability, less duplication. Could you also change it for other
constants in this file like `MILLIS_PER_HOUR` and `MILLIS_PER_DAY`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support extract epoch, decade, millisecond, microsecond
> -------------------------------------------------------
>
> Key: FLINK-9432
> URL: https://issues.apache.org/jira/browse/FLINK-9432
> Project: Flink
> Issue Type: New Feature
> Reporter: Sergey Nuyanzin
> Assignee: Sergey Nuyanzin
> Priority: Major
> Labels: pull-request-available
>
> The task is to separate activity from depending on
> https://issues.apache.org/jira/browse/CALCITE-2303 from all others that could
> be done without upgrade avatica/calcite in
> https://issues.apache.org/jira/browse/FLINK-8518
> Now the implementations of next functions are blocked
> {code:sql}
> extract(decade from ...)
> extract(epoch from ...)
> extract(millisecond from ...)
> extract(microsecond from ...)
> extract(isodow from ...)
> extract(isoyear from ...)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
