StefanRRichter commented on a change in pull request #6743: [FLINK-10411] Make
ClusterEntrypoint more compositional
URL: https://github.com/apache/flink/pull/6743#discussion_r220127856
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosJobClusterEntrypoint.java
##########
@@ -179,7 +111,15 @@ protected JobGraph retrieveJobGraph(Configuration
configuration) throws FlinkExc
}
@Override
- protected void
registerShutdownActions(CompletableFuture<ApplicationStatus> terminationFuture)
{}
+ protected ClusterComponent<?> createClusterComponent(Configuration
configuration) {
+ return new JobClusterComponent(
+ new MesosResourceManagerFactory(
+ mesosServices,
+ schedulerConfiguration,
+ taskManagerParameters,
+ taskManagerContainerSpec),
+ new
FileJobGraphRetriever(configuration.getString(JOB_GRAPH_FILE_PATH,
"job.graph")));
Review comment:
We could use a helper method that does construct `FileJobGraphRetriever`
from `configuration` because this is duplicated. At least `"job.graph"` could
become a string constant somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
