EugeneYushin opened a new pull request #6760: [FLINK-10422] Follow AWS specs in Kinesis Consumer URL: https://github.com/apache/flink/pull/6760 ## What is the purpose of the change Inline Flink Kinesis connector with AWS specs related to shard id conventions. Related Jira story: https://issues.apache.org/jira/browse/FLINK-10422 Mailing list conversation: https://lists.apache.org/thread.html/96de3bac9761564767cf283b58d664f5ae1b076e0c4431620552af5b@%3Cdev.flink.apache.org%3E ## Brief change log - Remove custom ShardId comparator logic as it's redundant, rely on AWS client libs to get shard list with exclusive start shard id - Remove test related cleaning in production code - Add tests to check correct shards a returned on second run of `listShards` method for 2 cases: new shards are present, no new shards ## Verifying this change This change added tests and can be verified as follows: - Run `testGetShardListWithNewShardsOnSecondRun/testGetShardWithNoNewShards` unit tests in `KinesisProxyTest.class` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
