[ 
https://issues.apache.org/jira/browse/FLINK-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628927#comment-16628927
 ] 

ASF GitHub Bot commented on FLINK-10400:
----------------------------------------

tillrohrmann commented on issue #6742: [FLINK-10400] Fail JobResult if 
application finished in CANCELED or FAILED state
URL: https://github.com/apache/flink/pull/6742#issuecomment-424755066
 
 
   Thanks for the review @TisonKun and @zentol. Merging this PR once Travis 
gives green light (after rebasing).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Return failed JobResult if job terminates in state FAILED or CANCELED
> ---------------------------------------------------------------------
>
>                 Key: FLINK-10400
>                 URL: https://issues.apache.org/jira/browse/FLINK-10400
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.6.1, 1.7.0, 1.5.4
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> If the job reaches the globally terminal state {{FAILED}} or {{CANCELED}}, 
> the {{JobResult}} must return a non-successful result. At the moment, it can 
> happen that in the {{CANCELED}} state where we don't find a failure cause 
> that we return a successful {{JobResult}}.
> In order to change this I propose to always return a {{JobResult}} with a 
> {{JobCancellationException}} in case of {{CANCELED}} and a 
> {{JobExecutionException}} in case of {{FAILED}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to